ilya-biryukov added inline comments.

================
Comment at: unittests/clangd/ClangdTests.cpp:118
+  llvm::SmallString<128> TmpDir2;
+  llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/true, TmpDir2);
+
----------------
bkramer wrote:
> We should delete those when we're done, otherwise the unit test will litter 
> /tmp on every run.
ASTUnit handles that, right?
It's only here to provide access to PCHs ASTUnit creates, we don't actually 
write to those dirs ourselves.


https://reviews.llvm.org/D33416



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to