ganenkokb-yandex wrote: > Code looks almost acceptable. I could not verify if the tests are sufficient > (I am not familiar with this new syntax). Can you test this on large projects > that use these types of expressions?
It is my approach. All fixes aside ASTImporter are came from real cases. I covered with tests all code paths for new decls and expressions for concepts, except ``` ImportExprRequirement ... if (FromTypeRequirement.isSubstitutionFailure()) --- how to get here? - it is compile time error? ``` Newly added VisitSubstNonTypeTemplateParmPackExpr, VisitPseudoObjectExpr, VisitCXXParenListInitExpr are also without tests. I've faced them on my project, and looks like it is not because of newly implemented concepts imports. But I'm not sure. Should I move 'em to separate pull request? https://github.com/llvm/llvm-project/pull/138838 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
