================ @@ -1590,25 +1590,70 @@ namespace { void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF, ---------------- tahonermann wrote:
This function is only ever called for a deleting destructor (and when `CXXStructorImplicitParamValue` is non-null). I don't think there is a reasonable way to assert that here, but it might be worth adding a comment. The function name is fine, but it wasn't sufficient for me to recognize that this function is only applicable to deleting destructors until I audited all of the call sites. https://github.com/llvm/llvm-project/pull/139566 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits