Author: Mikael Holmen Date: 2025-06-12T09:43:30+02:00 New Revision: 77062244ed56be61aecda28d6fede3432545f741
URL: https://github.com/llvm/llvm-project/commit/77062244ed56be61aecda28d6fede3432545f741 DIFF: https://github.com/llvm/llvm-project/commit/77062244ed56be61aecda28d6fede3432545f741.diff LOG: Fix two instances of -Wparentheses warnings [NFC] Add parentheses around the assert conditions. Without this gcc warned like ../lib/Target/AMDGPU/GCNSchedStrategy.cpp:2250: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 2250 | NewMI != RegionBounds.second && "cannot remove at region end"); and ../../clang/lib/Sema/SemaOverload.cpp:11326:39: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 11326 | DeferredCandidatesCount == 0 && | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ 11327 | "Unexpected deferred template candidates"); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Added: Modified: clang/lib/Sema/SemaOverload.cpp llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp Removed: ################################################################################ diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp index cf455f4588de3..89e86f49a3ca8 100644 --- a/clang/lib/Sema/SemaOverload.cpp +++ b/clang/lib/Sema/SemaOverload.cpp @@ -11322,9 +11322,9 @@ OverloadingResult OverloadCandidateSet::BestViableFunction(Sema &S, SourceLocation Loc, iterator &Best) { - assert(shouldDeferTemplateArgumentDeduction(S.getLangOpts()) || - DeferredCandidatesCount == 0 && - "Unexpected deferred template candidates"); + assert((shouldDeferTemplateArgumentDeduction(S.getLangOpts()) || + DeferredCandidatesCount == 0) && + "Unexpected deferred template candidates"); bool TwoPhaseResolution = DeferredCandidatesCount != 0 && !ResolutionByPerfectCandidateIsDisabled; diff --git a/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp b/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp index 0f80462050cda..7165cf89ca45d 100644 --- a/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp +++ b/llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp @@ -2246,8 +2246,8 @@ void PreRARematStage::finalizeGCNSchedStage() { void GCNScheduleDAGMILive::updateRegionBoundaries( RegionBoundaries &RegionBounds, MachineBasicBlock::iterator MI, MachineInstr *NewMI) { - assert(!NewMI || - NewMI != RegionBounds.second && "cannot remove at region end"); + assert((!NewMI || NewMI != RegionBounds.second) && + "cannot remove at region end"); if (RegionBounds.first == RegionBounds.second) { assert(NewMI && "cannot remove from an empty region"); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
