================
@@ -1831,6 +1831,22 @@ TEST_P(AArch64ExtensionDependenciesBaseCPUTestFixture,
}
}
+TEST(TargetParserTest, testAArch64ReconstructFromParsedFeatures) {
+ AArch64::ExtensionSet Extensions;
+ std::vector<std::string> FeatureOptions = {
+ "-sve2", "-Baz", "+sve", "+FooBar", "+sve2", "+neon", "-sve",
----------------
tmatheson-arm wrote:
I think the original intention was for it to be able to handle _either_
positive (added to the `ExtensionSet` without dependencies) or negative (marked
as "touched" on the `ExtensionSet`) for a given feature, but not see both of
them in the same list. As @labrinea pointed out though the code is not perfect,
the negative branch looks dead since `targetFeatureToExtension` doesn't handle
negative features.
https://github.com/llvm/llvm-project/pull/142236
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
