vbvictor wrote:

I think we generally discussed such changes in 
https://github.com/llvm/llvm-project/pull/138283,
CC @nicovank.

Maybe we need to come to consensus in clang-tidy whether we should write 
`assert()` after `Result.Nodes.getNodeAs<>`. (There are many-many places that 
has `assert` and that doesn't have `assert`)

Personally, I don't have a strong opinion on such changes, so from LGTM without 
explicit approval, please wait for a second opinion. 


https://github.com/llvm/llvm-project/pull/143145
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to