rjmccall added a comment. Looking good. We had some overlapping patches and comments there, so I want to make sure you didn't miss my comment on EmitAutoVarAlloca.
================ Comment at: lib/Sema/SemaDecl.cpp:7205 + } + assert (T.getAddressSpace() != LangAS::opencl_constant); + if (T.getAddressSpace() == LangAS::opencl_global) { ---------------- LLVM code style doesn't put a space after assert. https://reviews.llvm.org/D32248 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits