evelez7 wrote:

I think this patch is mostly ready in terms of functionality, but we should 
decide if the emitted files should follow the HTML or YAML style of creation. 
Right now, since I just ripped the Mustache generator code, it creates folders 
for each namespace and emits the nested entities there. This actually 
represents a problem for template specializations because the code tries to 
write another JSON object (the specialization) to the same file as the base 
template, which is invalid.

With YAML, each entity is emitted in a file that uses the entity's USR as a 
name. All files are emitted to the output directory without any folders. That 
conveniently solves the above template problem, but also results in ugly file 
names that are potentially bad for multi-file testing (right now, we use regex 
to find a USR file name to test YAML).

I'd say the HTML layout is nice, but then we'd need to decide what to call the 
specializations' files or whether to just include them as an object inside the 
base template's file.

https://github.com/llvm/llvm-project/pull/142483
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to