https://github.com/jmorse approved this pull request.
> It seems to me that manual finalizeSubprogram() calls were added > sporadically, not by following declaration-vs-definition logic. > With the call added [and with #119001], the test output changes: declaration > DISubprograms have their DICompositeTypes in the retainedNodes field. I think that's a good enough reason for this patch -- I get the feeling that the DIBuilder API has grown organically rather than being designed to fit a model, and this is just a further evolution of it. I can't think of any problems that this change would introduce. If there's some risk / problem that the patch introduces then we can always refine DIBuilder further. https://github.com/llvm/llvm-project/pull/139914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
