https://github.com/vbvictor commented:
Mostly left comments in docs about general improvements. Didn't look closely at the code, but here are some general recommendations that you should do before major review: There are a lot of new code that is relatively hard to review, you should try to follow [LLVM coding guidelines](https://llvm.org/docs/CodingStandards.html#style-issues), most importantly these: - [Don’t Use Braces on Simple Single-Statement Bodies of if/else/loop Statements](https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements) (many violations, with this fix the code should become smaller by line count, thus easier to review) - [Use range-based for loops wherever possible](https://llvm.org/docs/CodingStandards.html#use-range-based-for-loops-wherever-possible) https://github.com/llvm/llvm-project/pull/130421 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
