mcinally wrote:

> LGTM, though, I think we'd better reuse the code from `Clang.cpp`. 
> `flangFrontend` already depends on `clangDriver`, so we just need to export 
> `ParseMRecip` and `getRefinementStep` from `clangDriver` (and probably 
> replace their `Driver` argument with a `DiagnosticEngine` argument, so that 
> it works for both clang and flang).

This seems reasonable. I'll look into whether it's possible to do.

>  (and probably replace their `Driver` argument with a `DiagnosticEngine` 
> argument, so that it works for both clang and flang)

It will be interesting to see if Clang allows us to change this without 
changing it everywhere. Changing it everywhere seems like a heavy lift.

https://github.com/llvm/llvm-project/pull/142172
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to