================ @@ -3399,7 +3399,10 @@ void SelectionDAGBuilder::visitCallBr(const CallBrInst &I) { BasicBlock *Dest = I.getIndirectDest(i); MachineBasicBlock *Target = FuncInfo.getMBB(Dest); Target->setIsInlineAsmBrIndirectTarget(); - Target->setMachineBlockAddressTaken(); + // If there was a type of asm goto statement that was permitted to + // use an indirect call instruction to jump to its labels, then we + // would also have to call Target->setMachineBlockAddressTaken() + // here to mark the target block as requiring a BTI. ---------------- smithp35 wrote:
Worth adding a newline to imply that the comment isn't applying to the next line. https://github.com/llvm/llvm-project/pull/141562 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits