qinkunbao wrote: This PR change converts Matcher::Globs from StringMap to vector. However, after the change, some unit tests are broken. For example, ``` // build/unittests/Support/./SupportTests --gtest_filter=SpecialCaseListTest.Basic TEST_F(SpecialCaseListTest, Basic) { std::unique_ptr<SpecialCaseList> SCL = makeSpecialCaseList("# This is a comment.\n" "\n" "src:hello\n" "src:bye\n" "src:hi=category\n" "src:z*=category\n"); EXPECT_TRUE(SCL->inSection("", "src", "hello")); } ```
Investigation revealed that `bool GlobPattern::match(StringRef S)` fails to match the input "hello". Logs indicate a change in the `Prefix` within `GlobPattern` from "hello" to "hilo" at some points. https://github.com/llvm/llvm-project/pull/140964 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits