eZWALT wrote: > > > What I see in the source code that it is used as a boolean flag. Can we > > > transform it to bool? There is no need to keep it integer > > > > > > Please could you cite the exact line? I'm not sure if you are refering to > > the logic inside checkTransformableLoopNest or not. > > I check getNumGeneratedLoops() function usage. I see that it is used only in > 2 linesб which can be replaced by just a boolean
We could add a boolean function like 'AreThereGeneratedLoops()', but getGeneratedNumLoops() is also used to count the total loops inside 'AnalyzeLoopSequence', which feeds into NumGeneratedLoops in OMPFuseDirective. Changing its return type would break that. While we could remove NumGeneratedLoops out of OMPLoopTransformation AST nodes, it provides useful semantic flexibility for future transformations. There’s a tradeoff, but I believe keeping it does more good than harm. https://github.com/llvm/llvm-project/pull/140532 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
