pcc accepted this revision.
pcc added a comment.
LGTM
Unfortunate, but I guess this is in the same category as things like
`-fsized-deallocation`.
================
Comment at: lib/Driver/SanitizerArgs.cpp:573
+
+ // This is a workaround for a bug in gold and enabled by default for
non-ELF
+ // targets.
----------------
Maybe include a binutils PR reference so that we can remove this eventually?
================
Comment at: lib/Driver/SanitizerArgs.cpp:729
+ CmdArgs.push_back(
+ Args.MakeArgString("-fsanitize-address-globals-dead-stripping"));
+
----------------
I think you don't need MakeArgString for string literals.
Repository:
rL LLVM
https://reviews.llvm.org/D32886
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
