================ @@ -1861,13 +1867,23 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { let arguments = commonArgs; let builders = [OpBuilder<(ins "mlir::SymbolRefAttr":$callee, - "mlir::Type":$resType, - "mlir::ValueRange":$operands), [{ + "mlir::Type":$resType, + "mlir::ValueRange":$operands), + [{ $_state.addOperands(operands); $_state.addAttribute("callee", callee); if (resType && !isa<VoidType>(resType)) $_state.addTypes(resType); - }]>]; + }]>, ---------------- andykaylor wrote:
It would be nice to have comments indicating that one of these is intended for direct calls and the other is intended for indirect calls. https://github.com/llvm/llvm-project/pull/139748 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits