AaronBallman wrote: > Yeah, I think I can live with this. I think not supporting the arbitrary > order is more annoying to users than a slight degradation in source location > reporting.
The point @kadircet brings up about tooling is a good one, though. I'm not certain we need to revert the patch, but breaking a bunch of tools and making them cope with the source location change is pretty disruptive. I think we may need to consider refactoring source location handling for attributes more broadly to solve the underlying concerns. Thoughts @erichkeane? https://github.com/llvm/llvm-project/pull/133107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
