================ @@ -227,7 +227,7 @@ void SPIRVTargetCodeGenInfo::setCUDAKernelCallingConvention( // Convert HIP kernels to SPIR-V kernels. if (getABIInfo().getContext().getLangOpts().HIP) { FT = getABIInfo().getContext().adjustFunctionType( - FT, FT->getExtInfo().withCallingConv(CC_OpenCLKernel)); + FT, FT->getExtInfo().withCallingConv(CC_DeviceKernel)); ---------------- sarnex wrote:
Seems we still do need it, removing it results in these failures ``` Failed Tests (20): Clang :: CodeGenCUDA/amdgpu-atomic-ops.cu Clang :: CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu Clang :: CodeGenCUDA/amdgpu-kernel-attrs.cu Clang :: CodeGenCUDA/amdgpu-visibility.cu Clang :: CodeGenCUDA/builtins-amdgcn.cu Clang :: CodeGenCUDA/builtins-spirv-amdgcn.cu Clang :: CodeGenCUDA/host-used-device-var.cu Clang :: CodeGenCUDA/kernel-amdgcn.cu Clang :: CodeGenCUDA/kernel-arg-name-metadata.cu Clang :: CodeGenCUDA/kernel-args.cu Clang :: CodeGenCUDA/lambda-constexpr-capture.cu Clang :: CodeGenCUDA/lambda.cu Clang :: CodeGenCUDA/record-layout.cu Clang :: CodeGenCUDA/struct-mangling-number.cu Clang :: CodeGenCUDA/unnamed-types.cu Clang :: CodeGenCUDA/unused-global-var.cu Clang :: CodeGenHIP/hip-cumode.hip Clang :: CodeGenHIP/maybe_undef-attr-verify.hip Clang :: Headers/hip-header.hip Clang :: Misc/backend-resource-limit-diagnostics.hip ``` https://github.com/llvm/llvm-project/pull/137882 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits