Author: Kazu Hirata Date: 2025-05-11T19:09:25-07:00 New Revision: 918cdaef52e73b3884cf380362199765bed4e566
URL: https://github.com/llvm/llvm-project/commit/918cdaef52e73b3884cf380362199765bed4e566 DIFF: https://github.com/llvm/llvm-project/commit/918cdaef52e73b3884cf380362199765bed4e566.diff LOG: [TableGen] Use StringRef::substr instead of StringRef::slice (NFC) (#139485) StringRef::substr is shorter here because we can rely on its default second parameter. Added: Modified: clang/utils/TableGen/ClangDiagnosticsEmitter.cpp Removed: ################################################################################ diff --git a/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp b/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp index e72288801a830..e347b89a85d46 100644 --- a/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp +++ b/clang/utils/TableGen/ClangDiagnosticsEmitter.cpp @@ -1089,7 +1089,7 @@ Piece *DiagnosticTextBuilder::DiagText::parseDiagText(StringRef &Text, if (End) { Parsed.push_back(New<TextPiece>(Text.slice(0, End), "diagtext")); - Text = Text.slice(End, StringRef::npos); + Text = Text.substr(End); if (Text.empty()) break; } @@ -1103,7 +1103,7 @@ Piece *DiagnosticTextBuilder::DiagText::parseDiagText(StringRef &Text, // Extract the (optional) modifier. size_t ModLength = Text.find_first_of("0123456789<{"); StringRef Modifier = Text.slice(0, ModLength); - Text = Text.slice(ModLength, StringRef::npos); + Text = Text.substr(ModLength); ModifierType ModType = StringSwitch<ModifierType>{Modifier} .Case("select", MT_Select) .Case("enum_select", MT_EnumSelect) @@ -1154,7 +1154,7 @@ Piece *DiagnosticTextBuilder::DiagText::parseDiagText(StringRef &Text, Text = Text.drop_front(); // Drop '<' size_t EnumNameLen = Text.find_first_of('>'); EnumSelect->EnumName = Text.slice(0, EnumNameLen); - Text = Text.slice(EnumNameLen, StringRef::npos); + Text = Text.substr(EnumNameLen); ExpectAndConsume(">"); if (Text[0] != '{') @@ -1169,7 +1169,7 @@ Piece *DiagnosticTextBuilder::DiagText::parseDiagText(StringRef &Text, Text = Text.drop_front(); // '%' size_t OptionNameLen = Text.find_first_of("{"); EnumSelect->OptionEnumNames.push_back(Text.slice(0, OptionNameLen)); - Text = Text.slice(OptionNameLen, StringRef::npos); + Text = Text.substr(OptionNameLen); } else { EnumSelect->OptionEnumNames.push_back({}); } @@ -1206,7 +1206,7 @@ Piece *DiagnosticTextBuilder::DiagText::parseDiagText(StringRef &Text, assert(!Text.empty()); Plural->OptionPrefixes.push_back( New<TextPiece>(Text.slice(0, End), "diagtext")); - Text = Text.slice(End, StringRef::npos); + Text = Text.substr(End); Plural->Options.push_back( parseDiagText(Text, StopAt::PipeOrCloseBrace)); assert(!Text.empty() && "malformed %plural"); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
