https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/139455
StringRef::substr is shorter here because we can rely on its default
second parameter.
>From 4954a82909003f320866106a140efbc0757da707 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Sun, 11 May 2025 07:54:17 -0700
Subject: [PATCH] [Driver] Use StringRef::substr instead of StringRef::slice
(NFC)
StringRef::substr is shorter here because we can rely on its default
second parameter.
---
clang/lib/Driver/Job.cpp | 2 +-
clang/lib/Driver/ToolChain.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang/lib/Driver/Job.cpp b/clang/lib/Driver/Job.cpp
index f676b12c99a24..880e9e396c41e 100644
--- a/clang/lib/Driver/Job.cpp
+++ b/clang/lib/Driver/Job.cpp
@@ -184,7 +184,7 @@ rewriteIncludes(const llvm::ArrayRef<const char *> &Args,
size_t Idx,
StringRef FlagRef(Args[Idx + NumArgs - 1]);
assert((FlagRef.starts_with("-F") || FlagRef.starts_with("-I")) &&
"Expecting -I or -F");
- StringRef Inc = FlagRef.slice(2, StringRef::npos);
+ StringRef Inc = FlagRef.substr(2);
if (getAbsPath(Inc, NewInc)) {
SmallString<128> NewArg(FlagRef.slice(0, 2));
NewArg += NewInc;
diff --git a/clang/lib/Driver/ToolChain.cpp b/clang/lib/Driver/ToolChain.cpp
index 3c52abb0ab78e..664aafad0f680 100644
--- a/clang/lib/Driver/ToolChain.cpp
+++ b/clang/lib/Driver/ToolChain.cpp
@@ -1441,7 +1441,7 @@ std::string ToolChain::detectLibcxxVersion(StringRef
IncludePath) const {
StringRef VersionText = llvm::sys::path::filename(LI->path());
int Version;
if (VersionText[0] == 'v' &&
- !VersionText.slice(1, StringRef::npos).getAsInteger(10, Version)) {
+ !VersionText.substr(1).getAsInteger(10, Version)) {
if (Version > MaxVersion) {
MaxVersion = Version;
MaxVersionString = std::string(VersionText);
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
