================
@@ -4911,8 +4911,8 @@ std::optional<NullabilityKind> Type::getNullability() 
const {
 bool Type::canHaveNullability(bool ResultIfUnknown) const {
   QualType type = getCanonicalTypeInternal();
 
+  // We'll only see canonical types here.
----------------
efriedma-quic wrote:

Actually, maybe move this inside the define, like:

```
#define NON_CANONICAL_TYPE(Class, Parent)                                      \
  // We'll only see canonical types here.                                      \
  case Type::Class:                                                            \
    llvm_unreachable("non-canonical type");
```

(Not that the comment is really useful, but I don't want to modify it in a 
format-fixing commit.)

https://github.com/llvm/llvm-project/pull/138342
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to