================
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
                      DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
 endif()
 
-if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR
   ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
----------------
jeremyd2019 wrote:

I'd just do
```suggestion
if(LLVM_ENABLE_PIC OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
```

since `LIBCLANG_BUILD_STATIC` is documented to build a static libclang *in 
addition to* the shared libclang

https://github.com/llvm/llvm-project/pull/138343
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to