================ @@ -183,9 +195,26 @@ class Action : public clang::ASTFrontendAction { auto Results = analyze(AST.Roots, PP.MacroReferences, PP.Includes, &PI, getCompilerInstance().getPreprocessor(), HeaderFilter); - if (!Insert) + + if (!Insert) { + llvm::errs() + << "warning: `-insert=0` is deprecated in favor of `-disable-insert`. " + "The old flag was confusing since it suggested that inserts " + "were disabled by default, when they were actually enabled. " + "See https://github.com/llvm/llvm-project/issues/132983\n"; + } + + if (!Remove) { + llvm::errs() + << "warning: `-remove=0` is deprecated in favor of `-disable-remove`. " + "The old flag was confusing since it suggested that removes " + "were disabled by default, when they were actually enabled. " + "See https://github.com/llvm/llvm-project/issues/132983\n"; + } ---------------- AaronBallman wrote:
Two changes still missing here: 1) Change backticks around the command syntax into single quotes 2) Remove the link to the GitHub issue https://github.com/llvm/llvm-project/pull/132991 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits