bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land.
Thanks for your patience! LGTM with a minor comment below. ================ Comment at: test/Sema/vector-gcc-compat.c:101 + + v2i64_r = v2i64_a && 1; // expected-error {{invalid vector operand to binary expression ('v2i64' (vector of 2 'long long' values))}} + v2i64_r = v2i64_a || 1; // expected-error {{invalid vector operand to binary expression ('v2i64' (vector of 2 'long long' values))}} ---------------- sdardis wrote: > bruno wrote: > > Is this because of && and others only working in C++? If so, we need a > > better error message here, along the lines of "logical expression with > > vector only support in C++". If later on we decide to support it in > > non-C++, we then get rid of the warning. > > > > > > > Yes, these operators are oddly only available in C++. > > I've changed the error message to "logical expression with vector type[s] > '<typedef'd name>' (vector of <N> '<element type>' values) [and '<other > type>'] is only supported in C++". Great, can you also mention the type of the other hand side when it's not a vector? https://reviews.llvm.org/D25866 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits