fzou1 wrote:

> > > Any comments?
> > 
> > 
> > Still not understand the requirement...
> 
> I'm confused by the test cases too. I understood the code as we replace the 
> EGPR or NDD instructions with non-APX ones, which meets my expection. But the 
> option and tests are in MC phase, which means instructions and registers 
> cannot be changed any more. I think it's not correct to just change the 
> relocation type without changing instructions.

I've reverted the changes for disabling relocation type. A pass is added to fix 
the issue of unsupported relocation type, by avoiding emitting EGPR and NDD for 
instructions with relocations. NF instruction is assumed not to be emitted 
before this pass, so assertion is added there. And the NF optimizations had 
been disabled for instructions with relocations. Thanks @phoebewang 

https://github.com/llvm/llvm-project/pull/136660
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to