================ @@ -26,22 +26,14 @@ RootSignatureParser::RootSignatureParser(SmallVector<RootElement> &Elements, bool RootSignatureParser::parse() { // Iterate as many RootElements as possible - while (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) { - // Dispatch onto parser method. - // We guard against the unreachable here as we just ensured that CurToken - // will be one of the kinds in the while condition - switch (CurToken.TokKind) { - case TokenKind::kw_DescriptorTable: - if (parseDescriptorTable()) + do { + if (tryConsumeExpectedToken(TokenKind::kw_DescriptorTable)) { + auto Table = parseDescriptorTable(); + if (!Table.has_value()) ---------------- inbelic wrote:
I will merge as-is for now since this explicit version is already established in the file. I can create a clean-up pr later to adjust this throughout the whole file. https://github.com/llvm/llvm-project/pull/136747 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits