llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Nick Sarnie (sarnex) <details> <summary>Changes</summary> Based on feedback from https://github.com/llvm/llvm-project/pull/136753, remove the dummy values for OpenCL and make them match the zero default AS map. --- Full diff: https://github.com/llvm/llvm-project/pull/137187.diff 1 Files Affected: - (modified) clang/lib/Basic/Targets/SPIR.h (+5-7) ``````````diff diff --git a/clang/lib/Basic/Targets/SPIR.h b/clang/lib/Basic/Targets/SPIR.h index 310ef9f2df2c6..bf249e271a870 100644 --- a/clang/lib/Basic/Targets/SPIR.h +++ b/clang/lib/Basic/Targets/SPIR.h @@ -58,15 +58,13 @@ static const unsigned SPIRDefIsPrivMap[] = { // Used by both the SPIR and SPIR-V targets. static const unsigned SPIRDefIsGenMap[] = { 4, // Default - // Some OpenCL address space values for this map are dummy and they can't be - // used 1, // opencl_global - 0, // opencl_local - 0, // opencl_constant + 3, // opencl_local + 2, // opencl_constant 0, // opencl_private - 0, // opencl_generic - 0, // opencl_global_device - 0, // opencl_global_host + 4, // opencl_generic + 5, // opencl_global_device + 6, // opencl_global_host // cuda_* address space mapping is intended for HIPSPV (HIP to SPIR-V // translation). This mapping is enabled when the language mode is HIP. 1, // cuda_device `````````` </details> https://github.com/llvm/llvm-project/pull/137187 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
