================ @@ -107,15 +107,28 @@ CXString createCXString(CXStringBuf *buf) { return Str; } -CXStringSet *createSet(const std::vector<std::string> &Strings) { +template <typename StringTy, bool Copy> +static CXStringSet *createSetImpl(ArrayRef<StringTy> Strings) { ---------------- qiongsiwu wrote:
Ah yes this is good to keep in mind. I revised the call in `createSet` below to avoid explicitly constructing the `ArrayRef` so I think I will opt to keep the current implementation. https://github.com/llvm/llvm-project/pull/136773 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits