================
@@ -81,10 +81,6 @@ class FunctionSummariesTy {
I->second.MayInline = 0;
}
- void markReachedMaxBlockCount(const Decl *D) {
- markShouldNotInline(D);
- }
----------------
NagyDonat wrote:
I agree that it's OK to write code like
```c++
if (<reached condition X>)
markReachedConditionX(Args);
```
where every effect is grouped into a single function, I just say that it's a
bad pattern to hide a function with this kind of generic name in a large block
of mixed effects:
```c++
if (<reached condition X>) {
doSomething();
markReachedConditionX(Args);
if (InnerCondition) {
makeFoo();
return conjureBar();
} else {
//...
}
}
```
https://github.com/llvm/llvm-project/pull/136720
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
