llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/136391.diff 1 Files Affected: - (modified) clang-tools-extra/clang-doc/BitcodeReader.cpp (+34-34) ``````````diff diff --git a/clang-tools-extra/clang-doc/BitcodeReader.cpp b/clang-tools-extra/clang-doc/BitcodeReader.cpp index 1f2fb0a8b2b85..7935c108bc473 100644 --- a/clang-tools-extra/clang-doc/BitcodeReader.cpp +++ b/clang-tools-extra/clang-doc/BitcodeReader.cpp @@ -18,13 +18,13 @@ namespace doc { using Record = llvm::SmallVector<uint64_t, 1024>; // This implements decode for SmallString. -llvm::Error decodeRecord(const Record &R, llvm::SmallVectorImpl<char> &Field, +static llvm::Error decodeRecord(const Record &R, llvm::SmallVectorImpl<char> &Field, llvm::StringRef Blob) { Field.assign(Blob.begin(), Blob.end()); return llvm::Error::success(); } -llvm::Error decodeRecord(const Record &R, SymbolID &Field, +static llvm::Error decodeRecord(const Record &R, SymbolID &Field, llvm::StringRef Blob) { if (R[0] != BitCodeConstants::USRHashSize) return llvm::createStringError(llvm::inconvertibleErrorCode(), @@ -37,12 +37,12 @@ llvm::Error decodeRecord(const Record &R, SymbolID &Field, return llvm::Error::success(); } -llvm::Error decodeRecord(const Record &R, bool &Field, llvm::StringRef Blob) { +static llvm::Error decodeRecord(const Record &R, bool &Field, llvm::StringRef Blob) { Field = R[0] != 0; return llvm::Error::success(); } -llvm::Error decodeRecord(const Record &R, int &Field, llvm::StringRef Blob) { +static llvm::Error decodeRecord(const Record &R, int &Field, llvm::StringRef Blob) { if (R[0] > INT_MAX) return llvm::createStringError(llvm::inconvertibleErrorCode(), "integer too large to parse"); @@ -50,7 +50,7 @@ llvm::Error decodeRecord(const Record &R, int &Field, llvm::StringRef Blob) { return llvm::Error::success(); } -llvm::Error decodeRecord(const Record &R, AccessSpecifier &Field, +static llvm::Error decodeRecord(const Record &R, AccessSpecifier &Field, llvm::StringRef Blob) { switch (R[0]) { case AS_public: @@ -65,7 +65,7 @@ llvm::Error decodeRecord(const Record &R, AccessSpecifier &Field, } } -llvm::Error decodeRecord(const Record &R, TagTypeKind &Field, +static llvm::Error decodeRecord(const Record &R, TagTypeKind &Field, llvm::StringRef Blob) { switch (static_cast<TagTypeKind>(R[0])) { case TagTypeKind::Struct: @@ -80,7 +80,7 @@ llvm::Error decodeRecord(const Record &R, TagTypeKind &Field, "invalid value for TagTypeKind"); } -llvm::Error decodeRecord(const Record &R, std::optional<Location> &Field, +static llvm::Error decodeRecord(const Record &R, std::optional<Location> &Field, llvm::StringRef Blob) { if (R[0] > INT_MAX) return llvm::createStringError(llvm::inconvertibleErrorCode(), @@ -89,7 +89,7 @@ llvm::Error decodeRecord(const Record &R, std::optional<Location> &Field, return llvm::Error::success(); } -llvm::Error decodeRecord(const Record &R, InfoType &Field, +static llvm::Error decodeRecord(const Record &R, InfoType &Field, llvm::StringRef Blob) { switch (auto IT = static_cast<InfoType>(R[0])) { case InfoType::IT_namespace: @@ -105,7 +105,7 @@ llvm::Error decodeRecord(const Record &R, InfoType &Field, "invalid value for InfoType"); } -llvm::Error decodeRecord(const Record &R, FieldId &Field, +static llvm::Error decodeRecord(const Record &R, FieldId &Field, llvm::StringRef Blob) { switch (auto F = static_cast<FieldId>(R[0])) { case FieldId::F_namespace: @@ -122,14 +122,14 @@ llvm::Error decodeRecord(const Record &R, FieldId &Field, "invalid value for FieldId"); } -llvm::Error decodeRecord(const Record &R, +static llvm::Error decodeRecord(const Record &R, llvm::SmallVectorImpl<llvm::SmallString<16>> &Field, llvm::StringRef Blob) { Field.push_back(Blob); return llvm::Error::success(); } -llvm::Error decodeRecord(const Record &R, +static llvm::Error decodeRecord(const Record &R, llvm::SmallVectorImpl<Location> &Field, llvm::StringRef Blob) { if (R[0] > INT_MAX) @@ -139,7 +139,7 @@ llvm::Error decodeRecord(const Record &R, return llvm::Error::success(); } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, const unsigned VersionNo) { if (ID == VERSION && R[0] == VersionNo) return llvm::Error::success(); @@ -147,7 +147,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, "mismatched bitcode version number"); } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, NamespaceInfo *I) { switch (ID) { case NAMESPACE_USR: @@ -162,7 +162,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, RecordInfo *I) { switch (ID) { case RECORD_USR: @@ -185,7 +185,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, BaseRecordInfo *I) { switch (ID) { case BASE_RECORD_USR: @@ -208,7 +208,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, EnumInfo *I) { switch (ID) { case ENUM_USR: @@ -227,7 +227,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, TypedefInfo *I) { switch (ID) { case TYPEDEF_USR: @@ -244,7 +244,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, EnumValueInfo *I) { switch (ID) { case ENUM_VALUE_NAME: @@ -259,7 +259,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, FunctionInfo *I) { switch (ID) { case FUNCTION_USR: @@ -280,12 +280,12 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, TypeInfo *I) { return llvm::Error::success(); } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, FieldTypeInfo *I) { switch (ID) { case FIELD_TYPE_NAME: @@ -298,7 +298,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, MemberTypeInfo *I) { switch (ID) { case MEMBER_TYPE_NAME: @@ -311,7 +311,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, CommentInfo *I) { switch (ID) { case COMMENT_KIND: @@ -342,7 +342,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, Reference *I, FieldId &F) { switch (ID) { case REFERENCE_USR: @@ -363,14 +363,14 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, } } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, TemplateInfo *I) { // Currently there are no child records of TemplateInfo (only child blocks). return llvm::createStringError(llvm::inconvertibleErrorCode(), "invalid field for TemplateParamInfo"); } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, TemplateSpecializationInfo *I) { if (ID == TEMPLATE_SPECIALIZATION_OF) return decodeRecord(R, I->SpecializationOf, Blob); @@ -378,7 +378,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, "invalid field for TemplateParamInfo"); } -llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, +static llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, TemplateParamInfo *I) { if (ID == TEMPLATE_PARAM_CONTENTS) return decodeRecord(R, I->Contents, Blob); @@ -386,7 +386,7 @@ llvm::Error parseRecord(const Record &R, unsigned ID, llvm::StringRef Blob, "invalid field for TemplateParamInfo"); } -template <typename T> llvm::Expected<CommentInfo *> getCommentInfo(T I) { +template <typename T> static llvm::Expected<CommentInfo *> getCommentInfo(T I) { return llvm::createStringError(llvm::inconvertibleErrorCode(), "invalid type cannot contain CommentInfo"); } @@ -433,7 +433,7 @@ llvm::Expected<CommentInfo *> getCommentInfo(std::unique_ptr<CommentInfo> &I) { // the parent block to set it. The template specializations define what to do // for each supported parent block. template <typename T, typename TTypeInfo> -llvm::Error addTypeInfo(T I, TTypeInfo &&TI) { +static llvm::Error addTypeInfo(T I, TTypeInfo &&TI) { return llvm::createStringError(llvm::inconvertibleErrorCode(), "invalid type cannot contain TypeInfo"); } @@ -468,7 +468,7 @@ template <> llvm::Error addTypeInfo(TypedefInfo *I, TypeInfo &&T) { return llvm::Error::success(); } -template <typename T> llvm::Error addReference(T I, Reference &&R, FieldId F) { +template <typename T> static llvm::Error addReference(T I, Reference &&R, FieldId F) { return llvm::createStringError(llvm::inconvertibleErrorCode(), "invalid type cannot contain Reference"); } @@ -584,7 +584,7 @@ template <> llvm::Error addReference(RecordInfo *I, Reference &&R, FieldId F) { } template <typename T, typename ChildInfoType> -void addChild(T I, ChildInfoType &&R) { +static void addChild(T I, ChildInfoType &&R) { llvm::errs() << "invalid child type for info"; exit(1); } @@ -625,7 +625,7 @@ template <> void addChild(BaseRecordInfo *I, FunctionInfo &&R) { // TemplateParam children. These go into either a TemplateInfo (for template // parameters) or TemplateSpecializationInfo (for the specialization's // parameters). -template <typename T> void addTemplateParam(T I, TemplateParamInfo &&P) { +template <typename T> static void addTemplateParam(T I, TemplateParamInfo &&P) { llvm::errs() << "invalid container for template parameter"; exit(1); } @@ -638,7 +638,7 @@ void addTemplateParam(TemplateSpecializationInfo *I, TemplateParamInfo &&P) { } // Template info. These apply to either records or functions. -template <typename T> void addTemplate(T I, TemplateInfo &&P) { +template <typename T> static void addTemplate(T I, TemplateInfo &&P) { llvm::errs() << "invalid container for template info"; exit(1); } @@ -651,7 +651,7 @@ template <> void addTemplate(FunctionInfo *I, TemplateInfo &&P) { // Template specializations go only into template records. template <typename T> -void addTemplateSpecialization(T I, TemplateSpecializationInfo &&TSI) { +static void addTemplateSpecialization(T I, TemplateSpecializationInfo &&TSI) { llvm::errs() << "invalid container for template specialization info"; exit(1); } `````````` </details> https://github.com/llvm/llvm-project/pull/136391 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
