================
@@ -464,7 +464,8 @@ fatbinary(ArrayRef<std::pair<StringRef, StringRef>> 
InputFiles,
 } // namespace amdgcn
 
 namespace generic {
-Expected<StringRef> clang(ArrayRef<StringRef> InputFiles, const ArgList &Args) 
{
+Expected<StringRef> clang(ArrayRef<StringRef> InputFiles, const ArgList &Args,
+                          bool HasSYCLOffloadKind = false) {
----------------
asudarsa wrote:

I agree this change makes things better. Making OffloadKind enums to have 
power-of-two values and then using a bitfield here helps to avoid these flags 
and also helps to make the ActiveOffloadKinds support better. However, I would 
prefer to make these changes in a subsequent PR so that we can have a set of 
simpler commits. Please let me know if this is agreeable or you would prefer to 
make the change in this PR.

Thanks

https://github.com/llvm/llvm-project/pull/135683
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to