================
@@ -1302,6 +1302,7 @@ ItaniumRecordLayoutBuilder::LayoutBase(const 
BaseSubobjectInfo *Base) {
     setSize(std::max(getSize(), Offset + Layout.getSize()));
 
   // Remember max struct/class alignment.
+  UnadjustedAlignment = std::max(UnadjustedAlignment, PreferredBaseAlign);
----------------
efriedma-quic wrote:

Are we supposed to use the alignment of the base class, or the natural 
alignment of the base class?  I'd like to see testcases for both, and 
information about how gcc and msvc interpret that question.

Maybe also open a bug report at https://github.com/ARM-software/abi-aa/issues 
for a spec clarification; Arm is usually pretty responsive there.

------

I would also ask if you want BaseAlign vs. PreferredBaseAlign here, but as far 
as I can tell, they should be the same on AArch64.

https://github.com/llvm/llvm-project/pull/135564
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to