================ @@ -119,7 +119,7 @@ LANGOPT(WChar , 1, 0, "wchar_t keyword") LANGOPT(Char8 , 1, 0, "char8_t keyword") LANGOPT(IEEE128 , 1, 0, "__ieee128 keyword") LANGOPT(DeclSpecKeyword , 1, 0, "__declspec keyword") -BENIGN_LANGOPT(DollarIdents , 1, 1, "'$' in identifiers") +BENIGN_LANGOPT(DollarIdents , 1, 0, "'$' in identifiers") ---------------- zygoloid wrote:
Drive-by, but I think this should be a `COMPATIBLE_LANGOPT`, not a `BENIGN_LANGOPT`, since the same header built in the two different modes could generate different ASTs due to preprocessing differences. https://github.com/llvm/llvm-project/pull/135407 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits