topperc wrote: > > > Does this have any effect on the build time of the compiler? This file is > > > already large and I assume this significantly increases the size. > > > > > > Yes, the .inc size is 6 times larger. I don't know how to assess the > > impact, theoretically the time to read file and tokenize will increase but > > I think the impact won't be large because the file is only about 1.5 MB and > > the comments will be discarded after tokenizer. Do we really care how long > > it takes to compile the compiler? > > Compile of the compiler does get brought up sometimes. Here's a recent > example [#132252 > (comment)](https://github.com/llvm/llvm-project/pull/132252#issuecomment-2744451841)
I guess its not as bad as the 34MB RISCVGenInstrInfo.inc so maybe it won't be a problem. https://github.com/llvm/llvm-project/pull/133710 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
