================ @@ -2268,17 +2268,15 @@ static bool IsStandardConversion(Sema &S, Expr* From, QualType ToType, // handling here. if (ToType->isArrayParameterType()) { FromType = S.Context.getArrayParameterType(FromType); - SCS.First = ICK_HLSL_Array_RValue; } else if (FromType->isArrayParameterType()) { const ArrayParameterType *APT = cast<ArrayParameterType>(FromType); ---------------- inbelic wrote:
nit: ```suggestion } else if (const ArrayParameterType *APT = dyn_cast<ArrayParameterType>(FromType)) { ``` I think this is equivalent? The function seems to just be a wrapper to the `isa<..>` equivalent https://github.com/llvm/llvm-project/pull/134174 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits