efriedma-quic wrote: I'm mostly concerned about the case where the lowered node has the wrong type. For example, AArch64TargetLowering::LowerINTRINSIC_WO_CHAIN always creates a value with the pointer width of addrspace 0, but address spaces exist which don't have the native pointer width (arm64_32 exists, __ptr32 exists). And I suspect that inconsistency causes a crash. Even if it doesn't actually end up crashing in some cases, I'd prefer an explicit check to be on the safe side.
https://github.com/llvm/llvm-project/pull/132489 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits