================
@@ -16327,79 +16531,181 @@ static CanQualType RemoveAddressSpaceFromPtr(Sema
&SemaRef,
PtrTy->getPointeeType().getUnqualifiedType(), PtrQuals)));
}
-static inline bool
-CheckOperatorNewDeleteTypes(Sema &SemaRef, const FunctionDecl *FnDecl,
- CanQualType ExpectedResultType,
- CanQualType ExpectedFirstParamType,
- unsigned DependentParamTypeDiag,
- unsigned InvalidParamTypeDiag) {
- QualType ResultType =
- FnDecl->getType()->castAs<FunctionType>()->getReturnType();
+enum class AllocationOperatorKind { New, Delete };
+
+static bool IsPotentiallyTypeAwareOperatorNewOrDelete(Sema &SemaRef,
+ const FunctionDecl *FD,
+ bool *WasMalformed) {
+ const Decl *MalformedDecl = nullptr;
+ if (FD->getNumParams() > 0 &&
+ SemaRef.isStdTypeIdentity(FD->getParamDecl(0)->getType(),
+ /*TypeArgument=*/nullptr, &MalformedDecl))
+ return true;
- if (SemaRef.getLangOpts().OpenCLCPlusPlus) {
- // The operator is valid on any address space for OpenCL.
- // Drop address space from actual and expected result types.
- if (const auto *PtrTy = ResultType->getAs<PointerType>())
- ResultType = RemoveAddressSpaceFromPtr(SemaRef, PtrTy);
+ if (!MalformedDecl)
+ return false;
+
+ if (WasMalformed)
+ *WasMalformed = true;
+
+ // SemaRef.Diag(MalformedDecl->getLocation(),
+ // diag::err_malformed_std_class_template) << "type_identity";
----------------
ojhunt wrote:
Yup, hilariously I just saw it while looking for erroneous getLocation()
instead of getSourceRange(), I had to remind myself what this problem was.
Basically (from a QoL PoV) I'd like to diagnose "you are using <special type>
but the definition is wrong", however because the type decl is not actually
invalid it's wrong to mark it as such, and so we end up producing the same
diagnostic for the same type repeatedly.
For now it seems acceptable to not diagnose here and maintain the existing
semantics presented by initializer_list (which originated the malformed class
diagnostic) and only diagnose when we attempt to actually call the function.
https://github.com/llvm/llvm-project/pull/113510
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
