https://github.com/ilya-biryukov requested changes to this pull request.
There are two parts to this patch: 1. forwarding more methods properly 2. updating the interface, adding new callbacks and changing the behavior of `-dump-deserialized-decls`` I think (1) is a no-brainer. I would be very eager to LGTM it right away, but could you send it as a separate PR? (Especially if it fixes the crash) The part (2) is a bit more complicated and it would be great to explore the solution space a little more. I've left a comment about reentrancy into the callback that worries me, please take a look. Another point that we want to be explicit about is that this would change the buffering of `-dump-deserialized-decls`. It's definitely better than crashing, but we should at least mention in the patch description that the we are now doing extra buffering and certain declarations might be printed later than before. https://github.com/llvm/llvm-project/pull/133395 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
