ChuanqiXu9 wrote: LGTM generally.
Some other personal suggestion to the title, it might be better to add `[modules]` to the title. Since my mail filter will highlight these mails with the tag : ) This might be why I missed you last ping. https://github.com/llvm/llvm-project/pull/132214 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits