================
@@ -170,102 +132,112 @@ struct alignas(ConstraintAlignment)
FoldExpandedConstraint {
const Expr *Pattern)
: Kind(K), Constraint(std::move(C)), Pattern(Pattern) {};
- template <typename AtomicSubsumptionEvaluator>
- bool subsumes(const FoldExpandedConstraint &Other,
- const AtomicSubsumptionEvaluator &E) const;
-
static bool AreCompatibleForSubsumption(const FoldExpandedConstraint &A,
const FoldExpandedConstraint &B);
+
+ llvm::FoldingSetNodeID ProfileForSubsumption() const;
----------------
cor3ntin wrote:
This was just a (poorly named) attempt to produce a cache key for atomic
constraint generically (we do it in two places but both places do it
differently) - i just forgot to cleanup after myself
> Actually, should we be adding some time trace report support to this so users
> can track how much time is spent on subsumption in their headers?
Completely unrelated but it might be a good in a follow up. But what we should
profile there is more "how much time is spent finding the most constraint
candidate"
https://github.com/llvm/llvm-project/pull/132849
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
