jthackray wrote: > How'd you manage to find the right ones? IMO we should be using > include-what-you-use on these to make sure we get it right (if you have > already, disregard this).
Yes, I used iwyu. > Also, can you share before-split/after-split/after-this build time > benchmarks? Does this get us back to reasonable? I've pasted my own benchmarks in an above message. tl;dr, I didn't see any overall build time increase, but incremental build time reduction if only modifying `CGBuiltin.cpp` and `ARM.cpp` is cut in half from 35 seconds to 16 seconds, using clang. gcc 13 reduction was even greater, but mainly because gcc is so much slower at compilation than clang for this code. https://github.com/llvm/llvm-project/pull/132495 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
