carlosgalvezp wrote: My main concern about this patch is putting the implementation into the config file. We must be very careful with what we add to the config file, because it must remain there unchanged forever. We must have an upfront design that we believe will hold for the next N years without modification.
This is because clang-tidy not only analyzes our projects' own .clang-tidy file (which we can change), but it also analyzes the .clang-tidy files of the third-party projects we include (which we cannot change). `readability-identifier-naming` picks up any third-party .clang-tidy file anytime you include a third-party header (regardless of whether you later filter out those warnings or not). If the config file changes in a non-backwards compatible way, clang-tidy bails out and refuses to analyze anything, which is a big problem. This feature request requires adding *a lot* of things in the config file. And once it's in, people will want *more* things in it (eventually they will want exactly the same functionality as can be achieved by regular checks). So I see this feature growing without possibility of refactoring and cleaning, which can add a lot of complexity and maintenance work. It would feel safer if the custom check was passed via command-line instead, similar to `--config`. Then, we can be more aggressive with backwards-incompatible changes, because people running clang-tidy are in control of their CLI command and can adjust it upon breaking changes. Or simply another file entirely that does not have the problems I described. https://github.com/llvm/llvm-project/pull/131804 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
