https://github.com/frasercrmck commented:
Nice one! This appears only to fix the precision issues I see when in FTZ mode. Without FTZ mode, I still see, e.g., ``` 1: erfc fp32 ........... ERROR: erfc: -24.674929 ulp error at 0x1.3b8p+3 (0x411dc000): *0x1.9p-145 vs. 0x0p+0 ERROR: erfc: -62.341320 ulp error at 0x1.3ap+3 (0x411d0000): *0x1.fp-144 vs. 0x0p+0 ERROR: erfc: -33.623295 ulp error at 0x1.3bp+3 (0x411d8000): *0x1.1p-144 vs. 0x0p+0 ERROR: erfc: -18.099249 ulp error at 0x1.3cp+3 (0x411e0000): *0x1.2p-145 vs. 0x0p+0 ERROR: erfc: -45.794533 ulp error at 0x1.3a8p+3 (0x411d4000): *0x1.7p-144 vs. 0x0p+0 erfc FAILED ``` Though this does seem to be an improvement so it might be worth merging anyway. As you say, it fixes things for you and for mesa. Are you both testing on FTZ implementations, by any chance? I do see compiler warnings about the double-precision literals so those should be fixed up first. https://github.com/llvm/llvm-project/pull/132390 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
