steakhal wrote: > @steakhal Okay, glad to do it. But I don't know specifically about the > workflow of review. Could you give me some guidance?
How is this proposal different from yours? What do you think is objectively a better approach? Do the added tests cover the intended behavior? Would the test indeed fail without the fix, but pass with the fix? Which approach is more maintainable for the long run? Can we think of some other solutions that we haven't discussed yet? https://github.com/llvm/llvm-project/pull/132427 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
