https://github.com/BruceAko updated
https://github.com/llvm/llvm-project/pull/132320
>From bcf24c8442023fbe9283b0746ea5d2ba3ecfb86f Mon Sep 17 00:00:00 2001
From: BruceAko <chong...@hust.edu.cn>
Date: Fri, 21 Mar 2025 07:54:16 +0000
Subject: [PATCH] [clang] Fix nullptr dereference when checking friend default
comparison
Fix comparison check for explicitly defaulted functions by using
declaresSameEntity for friend declarations.
---
clang/lib/Sema/SemaDeclCXX.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index a1551e8027cd3..3298fc84db4e7 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -9039,8 +9039,7 @@ bool Sema::CheckExplicitlyDefaultedComparison(Scope *S,
FunctionDecl *FD,
return true;
if (llvm::none_of(RD->friends(), [&](const FriendDecl *F) {
- return FD->getCanonicalDecl() ==
- F->getFriendDecl()->getCanonicalDecl();
+ return declaresSameEntity(F->getFriendDecl(), FD);
})) {
Diag(FD->getLocation(), diag::err_defaulted_comparison_not_friend)
<< int(DCK) << int(0) << RD;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
