https://github.com/mpark created 
https://github.com/llvm/llvm-project/pull/131746

Addressing [nit 
comments](https://github.com/llvm/llvm-project/pull/129982#discussion_r1997914387)
 from @shafik

>From d8c4a3fe29bbd95d61d7b9c101912ae00b3d0c8a Mon Sep 17 00:00:00 2001
From: Michael Park <mcyp...@gmail.com>
Date: Tue, 18 Mar 2025 00:25:38 -0700
Subject: [PATCH] [NFC] Add a leading comment to boolean arguments.

---
 clang/lib/Serialization/ASTReader.cpp     | 3 ++-
 clang/lib/Serialization/ASTReaderDecl.cpp | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/clang/lib/Serialization/ASTReader.cpp 
b/clang/lib/Serialization/ASTReader.cpp
index 2c73501821bff..2b03446aaa30e 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -10825,7 +10825,8 @@ void ASTReader::FinishedDeserializing() {
     {
       // Guard variable to avoid recursively entering the process of passing
       // decls to consumer.
-      SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, 
false);
+      SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+                                                 /*NewValue=*/false);
 
       // Propagate exception specification and deduced type updates along
       // redeclaration chains.
diff --git a/clang/lib/Serialization/ASTReaderDecl.cpp 
b/clang/lib/Serialization/ASTReaderDecl.cpp
index 79bd41aa2644e..c3341e00bacef 100644
--- a/clang/lib/Serialization/ASTReaderDecl.cpp
+++ b/clang/lib/Serialization/ASTReaderDecl.cpp
@@ -4314,7 +4314,8 @@ void ASTReader::PassInterestingDeclsToConsumer() {
 
   // Guard variable to avoid recursively redoing the process of passing
   // decls to consumer.
-  SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer, false);
+  SaveAndRestore GuardPassingDeclsToConsumer(CanPassDeclsToConsumer,
+                                             /*NewValue=*/false);
 
   // Ensure that we've loaded all potentially-interesting declarations
   // that need to be eagerly loaded.

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to