alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
LG with one nit. Thank you for tracking down this bug and fixing it! ================ Comment at: lib/Basic/SourceManager.cpp:1153 + if (FilePos + 1 == LineEnd && FilePos > LineStart) { + const char *Buf = MemBuf->getBufferStart(); + if (Buf[FilePos - 1] == '\r' || Buf[FilePos - 1] == '\n') ---------------- I'd move this line before the outermost `if` and remove the identical line below. Repository: rL LLVM https://reviews.llvm.org/D31713 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits