ABataev added inline comments.
================ Comment at: lib/Driver/ToolChains/Cuda.cpp:495-506 + + StringRef PtxVersion = DriverArgs.getLastArgValue( + options::OPT_fopenmp_ptx_EQ); + CC1Args.push_back("+ptx42"); + if (DeviceOffloadingKind == Action::OFK_OpenMP && ---------------- I don't like this kind of code. It is better to make like this: ``` if (DeviceOffloadingKind == Action::OFK_OpenMP) CC1Args.push_back(DriverArgs.getLastArgValue(options::OPT_fopenmp_ptx_EQ, "+ptx42")); else CC1Args.push_back("+ptx42"); ``` or something like this Repository: rL LLVM https://reviews.llvm.org/D29660 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits