llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Imad Aldij (imdj) <details> <summary>Changes</summary> Change the name of the control variable `SecondArgIsLastNamedArgument` to `SecondArgIsLastNonVariadicArgument` for clarity and consistency. Following feedback on earlier PR that was merged: - #<!-- -->131238 --- Full diff: https://github.com/llvm/llvm-project/pull/131346.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+4-4) ``````````diff diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index e99e30d75df94..c8e8cb6f4c150 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -4867,14 +4867,14 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) { // current function or method. In C23 mode, if the second argument is an // integer constant expression with value 0, then we don't bother with this // check. - bool SecondArgIsLastNamedArgument = false; + bool SecondArgIsLastNonVariadicArgument = false; const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); if (std::optional<llvm::APSInt> Val = TheCall->getArg(1)->getIntegerConstantExpr(Context); Val && LangOpts.C23 && *Val == 0) return false; - // These are valid if SecondArgIsLastNamedArgument is false after the next + // These are valid if SecondArgIsLastNonVariadicArgument is false after the next // block. QualType Type; SourceLocation ParamLoc; @@ -4882,7 +4882,7 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) { if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { - SecondArgIsLastNamedArgument = PV == LastParam; + SecondArgIsLastNonVariadicArgument = PV == LastParam; Type = PV->getType(); ParamLoc = PV->getLocation(); @@ -4891,7 +4891,7 @@ bool Sema::BuiltinVAStart(unsigned BuiltinID, CallExpr *TheCall) { } } - if (!SecondArgIsLastNamedArgument) + if (!SecondArgIsLastNonVariadicArgument) Diag(TheCall->getArg(1)->getBeginLoc(), diag::warn_second_arg_of_va_start_not_last_non_variadic_param); else if (IsCRegister || Type->isReferenceType() || `````````` </details> https://github.com/llvm/llvm-project/pull/131346 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
