================
@@ -33,6 +33,14 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy {
llvm_unreachable("NYI: PPC double-double format for long double");
llvm_unreachable("Unsupported format for long double");
}
+
+ bool isSized(mlir::Type ty) {
+ if (mlir::isa<cir::PointerType, cir::ArrayType, cir::BoolType,
+ cir::IntType>(ty))
+ return true;
+ assert(0 && "Unimplemented size for type");
----------------
andykaylor wrote:
I think an assert is appropriate here. Perhaps the wording could be changed.
This should be returning an answer for every type that we expect to get here.
We don't expect non-CIR mlir types, like mlir::Integer.
```suggestion
assert(0 && "Unexpected MLIR type");
```
https://github.com/llvm/llvm-project/pull/130502
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
